Add inputs for cameraModel and videoType for calculating intrinsics - #281
Open
mattpetrucci wants to merge 4 commits into
Open
Add inputs for cameraModel and videoType for calculating intrinsics#281mattpetrucci wants to merge 4 commits into
mattpetrucci wants to merge 4 commits into
Conversation
Added inputs to computeAverageIntrinsics for camera model and video type.
csherry04
reviewed
Aug 27, 2026
…name gets triggered.
csherry04
reviewed
Aug 27, 2026
Comment on lines
+209
to
+210
| else: | ||
| camModels.append(cameraModel) |
Contributor
There was a problem hiding this comment.
Sorry I didn't notice before but I think it may also need a trial_name = trial_id here bc otherwise it doesn't reset in the main case meaning on a second iteration, the if trial_name == 'null' won't trigger @mattpetrucci
csherry04
reviewed
Aug 27, 2026
Comment on lines
220
to
221
| if not os.path.exists(video_path): | ||
| download_file(trial["videos"][0]["video"], video_path) |
Contributor
There was a problem hiding this comment.
Here if the camera model is input and the api request code isn't run this errors out so would have to skip for cases where that is true ie:
if not os.path.exists(video_path):
if cameraModel is not None:
raise FileNotFoundError(video_path)
download_file(trial["videos"][0]["video"], video_path)
but maybe you want the trial to get pulled from api regardless of whether the camera is input? Not sure what the best solution is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added inputs to computeAverageIntrinsics for camera model and video type. The code still has the option to calculate new intrinsics for an iPhone if the camera model is set to "None" and the video type is .mov.